Skip to content

Rewrote fibonacci.py (#5665) #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 31, 2021
Merged

Rewrote fibonacci.py (#5665) #5677

merged 16 commits into from
Oct 31, 2021

Conversation

citharus
Copy link
Contributor

@citharus citharus commented Oct 29, 2021 •
edited
Loading

Describe your change:

I rewrote fibonacci.py as it was requested in #5665. The changes I made include:

  • Separated the logic to calculate Fibonacci numbers into the get method.

  • Removed Out of Bound, by calculating the missing numbers with the stored sequence.

  • Created main function with new prompt.

  • Changed get method documentation.

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters, with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues, then the commit message contains Fixes: #{$ISSUE_NO}.

Fixes: #5665

@citharus citharus requested a review from Kush1101 as a code owner October 29, 2021 18:37
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 29, 2021
poyea
poyea reviewed Oct 30, 2021
View reviewed changes
dynamic_programming/fibonacci.py Outdated
Comment on lines 12 to 13
for _ in range(index):
self.sequence.append(self.sequence[-1] + self.sequence[-2])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put inside get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 30, 2021
@tianyizheng02
Copy link
Contributor

Thanks for the rewrite, @citharus! Make sure to link this PR to the original issue so GitHub knows to close the issue automatically when this PR gets merged (just Fixes #5665 or something like that in your original comment will do)

poyea
poyea approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 31, 2021
@poyea poyea merged commit 868c2fa into TheAlgorithms:master Oct 31, 2021
@tianyizheng02 tianyizheng02 mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite fibonacci.py
3 participants
@citharus @tianyizheng02 @poyea