Skip to content

[mypy] Add/fix type annotations in data_structures/heap/skew_heap.py #5634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2021
Merged

[mypy] Add/fix type annotations in data_structures/heap/skew_heap.py #5634

merged 4 commits into from
Oct 31, 2021

Conversation

dylanbuchi
Copy link
Contributor

@dylanbuchi dylanbuchi commented Oct 27, 2021 •
edited
Loading

Describe your change:

  • Add Abstract Base Class Comparable
  • [mypy] add and fix type annotations (strict mode)
  • Fix a typo
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 27, 2021
l3str4nge
l3str4nge reviewed Oct 30, 2021
View reviewed changes
data_structures/heap/skew_heap.py Outdated

T = TypeVar("T")

class Comparable(metaclass=ABCMeta):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that class is used to make the generic type T comparable.
Without it, we get this mypy error: Unsupported left operand type for > ("T")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found another solution that doesn't need the class, so I will make an update. @l3str4nge

@dylanbuchi dylanbuchi requested a review from l3str4nge October 30, 2021 20:41
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2021
@l3str4nge l3str4nge merged commit 99983c9 into TheAlgorithms:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanbuchi @l3str4nge