Skip to content

add check_cycle.py #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2021
Merged

add check_cycle.py #5475

merged 5 commits into from
Oct 23, 2021

Conversation

atishaye
Copy link
Contributor

Describe your change:

Added check_cycle.py file

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 20, 2021
@poyea
Copy link
Member

poyea commented Oct 22, 2021

I'd suggest we add this check_cycle in one of https://github.com/TheAlgorithms/Python/tree/master/graphs. for example graphs/graph_list.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 22, 2021
@atishaye
Copy link
Contributor Author

I'd suggest we add this check_cycle in one of https://github.com/TheAlgorithms/Python/tree/master/graphs. for example graphs/graph_list.py

I think that it would be more useful in graphs/g_topological_sort.py. Here, the check_cycle function would first ensure that the given graph is a DAG. Only if the check_cycle function returns false, it would allow the topological sort to perform.
Let me know your thoughts on this and then I will proceed to implement it.

@ghost ghost removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 23, 2021
@atishaye
Copy link
Contributor Author

Hi @cclauss!
I am still new to open source. So, I was wondering if I have to make any changes to my existing code/commit the above suggestions or if the branch is ready to be merged?

@cclauss
Copy link
Member

cclauss commented Oct 23, 2021

If the PR is OPEN then the pull request has not yet been merged and you can continue making commits.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 23, 2021
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2021
@cclauss cclauss merged commit c50f0c5 into TheAlgorithms:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants