Replace double_ended_queue.py

[bqwstt]

Replaced double_ended_queue.py with an implementation of it with nodes.

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[ghost]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[poyea]

We can replace this file https://github.com/TheAlgorithms/Python/blob/master/data_structures/queue/double_ended_queue.py with your implementation, but use collections.deque in tests. Do you agree with this approach? @grbenjamin We can then demonstrate both implementations.

[bqwstt]

We can replace this file https://github.com/TheAlgorithms/Python/blob/master/data_structures/queue/double_ended_queue.py with your implementation, but use collections.deque in tests. Do you agree with this approach? @grbenjamin We can then demonstrate both implementations.

@poyea I do! I added the comparison on each doctest. Tell me if it's ok.
I also added extend() and extendleft(), to make it a bit more complete.

[bqwstt]

Fixed issues with pre-commit. Hopefully that works.

[poyea]

https://docs.python.org/3/library/doctest.html

if __name__ == "__main__":
    import doctest

    doctest.testmod()

[poyea]

@grbenjamin Please simply use this file to replace the existing data_structures/queue/double_ended_queue.py and use collections.deque in docstrings for testing.

We can replace this file https://github.com/TheAlgorithms/Python/blob/master/data_structures/queue/double_ended_queue.py with your implementation, but use collections.deque in tests. Do you agree with this approach? @grbenjamin We can then demonstrate both implementations.

[poyea]

I guess we can do:

list(built_in_deque) == list(our_deque)

?

[bqwstt]

@grbenjamin Please simply use this file to replace the existing data_structures/queue/double_ended_queue.py and use collections.deque in docstrings for testing.

We can replace this file https://github.com/TheAlgorithms/Python/blob/master/data_structures/queue/double_ended_queue.py with your implementation, but use collections.deque in tests. Do you agree with this approach? @grbenjamin We can then demonstrate both implementations.

Please provide an example of use of collections.deque in docstrings, I don't really understand what you mean. Is the way I do it incorrect?

[bqwstt]

I guess we can do:

list(built_in_deque) == list(our_deque)

?

In

def is_empty(self) -> bool:
    """
    >>> ...
    >>> list(built_in_deque) == list(our_deque)
    """
    ...

? Or in all other doctests? @poyea

[poyea]

I guess we can do:

list(built_in_deque) == list(our_deque)

?

In

def is_empty(self) -> bool:
    """
    >>> ...
    >>> list(built_in_deque) == list(our_deque)
    """
    ...

? Or in all other doctests? @poyea

@grbenjamin Yes, something like this, wherever we want to test the implementation : https://docs.python.org/3/library/collections.html?highlight=deque#collections.deque
we can do this in all other doctests

[poyea]

@grbenjamin Please simply use this file to replace the existing data_structures/queue/double_ended_queue.py and use collections.deque in docstrings for testing.

We can replace this file https://github.com/TheAlgorithms/Python/blob/master/data_structures/queue/double_ended_queue.py with your implementation, but use collections.deque in tests. Do you agree with this approach? @grbenjamin We can then demonstrate both implementations.

Please provide an example of use of collections.deque in docstrings, I don't really understand what you mean. Is the way I do it incorrect?

>>> from collections import deque
>>> d_collections = deque('123456')

etc.

[bqwstt]

Done, replaced the existing file and added more tests.

[poyea]

Looks good. Thank you for your pull request!🤩