Skip to content

Create count_1s_brian_kernighan_method #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

jainendra
Copy link
Contributor

@jainendra jainendra commented Oct 17, 2021

Ref - http://graphics.stanford.edu/~seander/bithacks.html#CountBitsSetKernighan
Created as part of Hacktoberfest challenge, please add hacktoberfest-accepted if/when merged

Describe your change:

Used Brian Kernighan's way to calculate the count of 1s in binary representation of a number. This method reduces the iteration count than how 1s are normally counted
Refer -
http://graphics.stanford.edu/~seander/bithacks.html#CountBitsSetKernighan
and https://www.geeksforgeeks.org/count-set-bits-in-an-integer/

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 17, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 18, 2021
@l3str4nge l3str4nge merged commit d28463c into TheAlgorithms:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants