Skip to content

Added Quicksort #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Added Quicksort #5295

wants to merge 5 commits into from

Conversation

rsh-raj
Copy link

@rsh-raj rsh-raj commented Oct 14, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2021
ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

divide_and_conquer/quick_sort.py Outdated
@@ -0,0 +1,40 @@
# Implementation of Quick sort algo-> https://en.wikipedia.org/wiki/Quicksort
class QuickSort():
def __init__(self, array,asc=True)->None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide type hint for the parameter: array

Please provide type hint for the parameter: asc

divide_and_conquer/quick_sort.py Outdated
self.asc=asc
self.array = array

def partition(self, start, end)->integer: # Will sort in ascending order by default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quick_sort.py, please provide doctest for the function partition

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

divide_and_conquer/quick_sort.py Outdated
j += 1
self.array[start], self.array[i] = self.array[i], self.array[start]
return i
def sort(self,start,end)->None: #recursive implementation of quick sort
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quick_sort.py, please provide doctest for the function sort

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

@ghost ghost removed the require type hints https://docs.python.org/3/library/typing.html label Oct 14, 2021
ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

divide_and_conquer/quick_sort.py
self.asc=asc
self.array = array

def partition(self, start:int, end:int)->int: # Will sort in ascending order by default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quick_sort.py, please provide doctest for the function partition

divide_and_conquer/quick_sort.py
j += 1
self.array[start], self.array[i] = self.array[i], self.array[start]
return i
def sort(self,start:int,end:int)->None: #recursive implementation of quick sort
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quick_sort.py, please provide doctest for the function sort

@ghost ghost removed the require tests Tests [doctest/unittest/pytest] are required label Oct 14, 2021
@rsh-raj rsh-raj mentioned this pull request Oct 14, 2021
Closed
@rsh-raj rsh-raj changed the title Added Qucik sort Added Quicksort Oct 14, 2021
@cclauss
Copy link
Member

cclauss commented Oct 14, 2021

We have enough quicksorts... https://github.com/TheAlgorithms/Python/search?q=quicksort

@cclauss cclauss closed this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsh-raj @cclauss