Skip to content

[mypy] fix type annotations for graphs/a_star.py #4052 #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 22, 2021
Merged

[mypy] fix type annotations for graphs/a_star.py #4052 #5224

merged 12 commits into from
Oct 22, 2021

Conversation

NumberPiOso
Copy link
Contributor

@NumberPiOso NumberPiOso commented Oct 11, 2021 •
edited
Loading

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 11, 2021
@poyea
Copy link
Member

poyea commented Oct 18, 2021

Let's add a if __name__ == "__main__": block as well

poyea
poyea reviewed Oct 18, 2021
View reviewed changes
@NumberPiOso @poyea
rename delta by DIRECTIONS
0703210 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 18, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 18, 2021
poyea
poyea reviewed Oct 19, 2021
View reviewed changes
poyea
poyea reviewed Oct 19, 2021
View reviewed changes
poyea
poyea reviewed Oct 19, 2021
View reviewed changes
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 22, 2021
@poyea poyea self-assigned this Oct 22, 2021
poyea
poyea approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 22, 2021
@poyea poyea merged commit 0616148 into TheAlgorithms:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NumberPiOso @poyea