Skip to content

Add surface area of cone and cylinder and hemisphere #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 14, 2021
Merged

Add surface area of cone and cylinder and hemisphere #5220

merged 8 commits into from
Oct 14, 2021

Conversation

Rohanrbharadwaj
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 10, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 11, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title Add surface area of cone and cylinder.py Add surface area of cone and cylinder Oct 11, 2021
@Rohanrbharadwaj
Copy link
Contributor Author

Rohanrbharadwaj commented Oct 13, 2021 •
edited
Loading

@cclauss Waiting for your approval on this...

@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 14, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title Add surface area of cone and cylinder Add surface area of cone and cylinder and hemisphere Oct 14, 2021
cclauss
cclauss reviewed Oct 14, 2021
View reviewed changes
maths/area.py
235.61944901923448
>>> surface_area_hemisphere(1)
9.42477796076938
>>> surface_area_hemisphere(-1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for surface_area_hemisphere(1.1) and surface_area_hemisphere(0).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not there for the other solids, but sure

cclauss
cclauss approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2021
@cclauss cclauss merged commit d561de0 into TheAlgorithms:master Oct 14, 2021
@Rohanrbharadwaj
Copy link
Contributor Author

Thanks.. And while I have you, do have a look at #5251 and #5222

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Rohanrbharadwaj @shermanhui
Add surface area of cone and cylinder and hemisphere (TheAlgorithms#5220
a20e092 
)

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Update area.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohanrbharadwaj @cclauss