made all files python3 compatible #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the files going to be compatible with BOTH Python 2 and Python 3 or is this a one-way conversion to Python 3-only? |
|
@cclauss one way to python 3 but EOL is a while away |
|
435 days until Python 2 end of life. |
|
@cclauss might as well start switching now |
|
I switched years ago ;-) |
|
@AlexDvorak Perhaps you could add the .lgtm.yml change from #510 and make sure the tests still pass. |
|
will do |
|
@AlexDvorak @cclauss I'll resolve the conflict and reanalyze the code. If everything goes well, I'll merge this by tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #485