Fix markdown for normal distribution quicksort #4875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MD001/heading-increment/header-increment: Heading levels should only increment by one level at a time - MD012/no-multiple-blanks: Multiple consecutive blank lines - MD026/no-trailing-punctuation: Trailing punctuation in heading - MD035/hr-style: Horizontal rule style - MD045/no-alt-text: Images should have alternate text (alt text) Conventions from https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md
ghost
added
awaiting reviews
chakeson
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Clearly an improvement. Here is the original one for full view and here is the new one.
poyea
reviewed
Oct 18, 2021
Comment on lines
3
to
+4
| Algorithm implementing QuickSort Algorithm where the pivot element is chosen randomly between first and last elements of the array and the array elements are taken from a Standard Normal Distribution. | ||
| This is different from the ordinary quicksort in the sense, that it applies more to real life problems , where elements usually follow a normal distribution. Also the pivot is randomized to make it a more generic one. | ||
|
|
||
| This is different from the ordinary quicksort in the sense, that it applies more to real life problems, where elements usually follow a normal distribution. Also the pivot is randomized to make it a more generic one. |
There was a problem hiding this comment.
Not so well written. Could you also improve it?
poyea
reviewed
Oct 18, 2021
| Algorithm implementing QuickSort Algorithm where the pivot element is chosen randomly between first and last elements of the array and the array elements are taken from a Standard Normal Distribution. | ||
| This is different from the ordinary quicksort in the sense, that it applies more to real life problems , where elements usually follow a normal distribution. Also the pivot is randomized to make it a more generic one. | ||
|
|
||
| This is different from the ordinary quicksort in the sense, that it applies more to real life problems, where elements usually follow a normal distribution. Also the pivot is randomized to make it a more generic one. | ||
|
|
||
| ## Array Elements | ||
|
|
||
| The array elements are taken from a Standard Normal Distribution , having mean = 0 and standard deviation 1. |
There was a problem hiding this comment.
Suggested change
| The array elements are taken from a Standard Normal Distribution , having mean = 0 and standard deviation 1. | |
| The array elements are taken from a Standard Normal Distribution, having mean = 0 and standard deviation = 1. |
There was a problem hiding this comment.
Add a link to Standard Normal Distribution
poyea
reviewed
Oct 18, 2021
| --- | ||
|
|
||
| --------------------- | ||
|  |
There was a problem hiding this comment.
Use the one in Wikimedia: https://upload.wikimedia.org/wikipedia/commons/thumb/2/25/The_Normal_Distribution.svg/1280px-The_Normal_Distribution.svg.png, which is in public domain
poyea
changed the title
poyea
changed the title
poyea
reviewed
Oct 18, 2021
Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conventions from https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.