Skip to content

Random anime character info #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 19, 2021
Merged

Random anime character info #4553

merged 7 commits into from
Jul 19, 2021

Conversation

ashish-patwal
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ashish-patwal ashish-patwal requested a review from cclauss as a code owner July 18, 2021 15:10
@ghost ghost added require tests Tests [doctest/unittest/pytest] are required awaiting reviews This PR is ready to be reviewed labels Jul 18, 2021
ghost
ghost reviewed Jul 18, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

random_anime_character.py Outdated
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file random_anime_character.py, please provide doctest for the function save_image

random_anime_character.py Outdated
file.write(image.content)


def random_anime_character() -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file random_anime_character.py, please provide doctest for the function random_anime_character

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py Outdated
file.write(image.content)


def random_anime_character() -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this script produces a random string of characters and info , i cannot presume and assert any conditions for the test . Thus doctests were not included .

ghost
ghost reviewed Jul 18, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py Outdated
file.write(image.content)


def random_anime_character() -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

@ashish-patwal
Copy link
Contributor Author

updates : black formatted the file as well as did pre-commit .
ptal @cclauss

@ghost ghost added the tests are failing Do not merge until tests pass label Jul 18, 2021
@cclauss
Copy link
Member

cclauss commented Jul 18, 2021

Run mypy .

web_programming/random_anime_character.py:38: error: No return value expected
web_programming/random_anime_character.py:42: error: "random_anime_character" does not return a value
Found 2 errors in 1 file (checked 316 source files)

@TheAlgorithms TheAlgorithms deleted a comment from ASHIKSAR Jul 18, 2021
ghost
ghost reviewed Jul 19, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py Outdated
return None


def random_anime_character() -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

@ashish-patwal
Copy link
Contributor Author

I did all the tests and the script passed all of them . pre-commit , black formatting , flake8 . Can you please take one more look @cclauss . Doctests can't be created for this script therefore ommitted .

cclauss
cclauss requested changes Jul 19, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix type hints until mypy passes.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jul 19, 2021
@ashish-patwal @cclauss
type hint updated
0341083 
Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
ghost reviewed Jul 19, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py Outdated
return None


def random_anime_character() -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jul 19, 2021
@ashish-patwal @cclauss
type hint updated again
5375cba 
Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
ghost reviewed Jul 19, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py
return None


def random_anime_character() -> tuple[str, str, str]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

@ashish-patwal ashish-patwal requested a review from cclauss July 19, 2021 10:46
cclauss
cclauss reviewed Jul 19, 2021
View reviewed changes
web_programming/random_anime_character.py Outdated
Comment on lines 18 to 19

return None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return None

This can safely be deleted. We would only use return None on functions that could return other values.

ghost
ghost reviewed Jul 19, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/random_anime_character.py
URL = "https://www.mywaifulist.moe/random"


def save_image(image_url: str, image_title: str) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

web_programming/random_anime_character.py
file.write(image.content)


def random_anime_character() -> tuple[str, str, str]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

cclauss
cclauss approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your persistence. Well done.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 19, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 19, 2021
@cclauss cclauss merged commit eca37b1 into TheAlgorithms:master Jul 19, 2021
@ashish-patwal
Copy link
Contributor Author

Looks good to me. Thanks for your persistence. Well done.

Thank you as well . I learnt a lot .

@ashish-patwal ashish-patwal deleted the random_anime branch July 19, 2021 17:37
@ashish-patwal ashish-patwal restored the random_anime branch July 19, 2021 17:37
@ashish-patwal ashish-patwal deleted the random_anime branch July 19, 2021 17:38
@ashish-patwal ashish-patwal restored the random_anime branch July 19, 2021 17:38
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@ashish-patwal @cclauss @shermanhui
Random anime character info (TheAlgorithms#4553)
e9cf8b5 
* fixed colons and spaces

* fixed colons and spaces

* random anime character python script

* more tests passed

* type hint updated

Co-authored-by: Christian Clauss <cclauss@me.com>

* type hint updated again

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update random_anime_character.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashish-patwal @cclauss