add phone_validator method #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l3str4nge
requested changes
Jul 19, 2021
strings/phone_validator.py
Outdated
| False | ||
| """ | ||
| # Created a regex pattern to produce a valid phone number | ||
| pat = re.compile(r"^(\+91[\-\s]?)?[0]?(91)?[789]\d{9}$") |
There was a problem hiding this comment.
Why only +91 ? It's not very universal. Consider create function for each country.
There was a problem hiding this comment.
Ok, I change this function as a indian_phone_validator.
strings/phone_validator.py
Outdated
| if match: | ||
| # the match is the same as the phone string it means they are valid phone number. | ||
| return match.string == phone | ||
| # if match are none so return False. |
There was a problem hiding this comment.
All of these comments are redundant. Please remove
There was a problem hiding this comment.
ok, i removed them.
ghost
added
awaiting changes
ghost
added
awaiting reviews
|
I'm back
…On Mon, Jul 19, 2021, 9:30 PM SURYAPRATAP SINGH SURYAVANSHI < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In strings/phone_validator.py
<#4552 (comment)>:
> + >>> phone_validator("01234567896")
+ False
+ >>> phone_validator("919876543218")
+ True
+ >>> phone_validator("+91-1234567899")
+ False
+ """
+ # Created a regex pattern to produce a valid phone number
+ pat = re.compile(r"^(\+91[\-\s]?)?[0]?(91)?[789]\d{9}$")
+ # Find their matches
+ match = re.search(pat, phone)
+ # if match are present
+ if match:
+ # the match is the same as the phone string it means they are valid phone number.
+ return match.string == phone
+ # if match are none so return False.
ok, i removed them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4552 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU4MCLDPU55PKVNTMFO46JDTYRAIDANCNFSM5AR2IMOQ>
.
|
l3str4nge
requested changes
Jul 19, 2021
ghost
added
awaiting changes
ghost
added
awaiting reviews
|
Tests are failing |
l3str4nge
requested changes
Jul 20, 2021
ghost
added
awaiting changes
|
if name == "main":
|
|
Logs tell you everything! :) |
ghost
added
awaiting reviews
|
Please reformat code with |
l3str4nge
approved these changes
Jul 20, 2021
|
Thanks, this is my first contribution to the open-source world. |
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* add phone_validator method
* change the phone_validator to indian_phone_validator
* Unnecessary comments removed
* all comments deleted
* Fixes: #{} new line issue
* code reformatted using black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.