Skip to content

Fix mypy errors at kruskal_2 #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mhihasan
Copy link
Contributor

@mhihasan mhihasan commented Jul 5, 2021

Describe your change:

  • Fix mypy errors at kruskal_2 algo

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related issue #4052

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 5, 2021
@mhihasan mhihasan force-pushed the fix/mypy_error_on_kruskal_2 branch 3 times, most recently from 415118f to 0b2bc90 Compare July 5, 2021 16:17
@mhihasan mhihasan force-pushed the fix/mypy_error_on_kruskal_2 branch from 0b2bc90 to 3035850 Compare July 5, 2021 16:28
@l3str4nge l3str4nge merged commit 256c319 into TheAlgorithms:master Jul 8, 2021
@ghost ghost removed awaiting reviews This PR is ready to be reviewed labels Jul 8, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants