Skip to content

Improves readability and processing time #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2021
Merged

Improves readability and processing time #4510

merged 2 commits into from
Jul 12, 2021

Conversation

dpittaluga76
Copy link
Contributor

@dpittaluga76 dpittaluga76 commented Jun 16, 2021 •
edited
Loading

This removes lambdas, improves readability and processing time when it finds bitstring to print out.

  • Enhancement

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Python naming conventions.

@dpittaluga76
Removes overuse of lambdas, improves readability and processing time …
af21b48 
…when it finds bitstring to print out.

 Removes overuse of lambdas, uses dictionary instead.  This improves readability and processing time when it finds the bitstring to print out.
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 16, 2021
@dpittaluga76 dpittaluga76 changed the title Removes overuse of lambdas, improves readability and processing time Removes usage of lambdas, improves readability and processing time Jun 16, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Jun 20, 2021
@dpittaluga76 dpittaluga76 changed the title Removes usage of lambdas, improves readability and processing time Improves readability and processing time Jul 2, 2021
@ghost ghost removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 12, 2021
@l3str4nge l3str4nge merged commit 2cbadc8 into TheAlgorithms:master Jul 12, 2021
@dpittaluga76 dpittaluga76 deleted the Fix-huffman-add-dict-printout branch July 14, 2021 20:47
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dpittaluga76 @shermanhui
Improves readability and processing time (TheAlgorithms#4510)
121aefe 
* Removes overuse of lambdas, improves readability and processing time when it finds bitstring to print out.

 Removes overuse of lambdas, uses dictionary instead.  This improves readability and processing time when it finds the bitstring to print out.

* Update huffman.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpittaluga76 @l3str4nge