Skip to content

CONTRIBUTING.md: Write for current Python #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

CONTRIBUTING.md: Write for current Python #4507

merged 1 commit into from
Jun 13, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jun 12, 2021

Describe your change:

CONTRIBUTING.md: Write for current Python

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Jun 12, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 13, 2021
@dhruvmanila dhruvmanila merged commit 10d38ea into master Jun 13, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
CONTRIBUTING.md: Write for current Python (TheAlgorithms#4507)
fd749b3
@dhruvmanila dhruvmanila deleted the Write-for-current-Python branch October 1, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PANDATD PANDATD PANDATD approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

@dhruvmanila dhruvmanila

Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @PANDATD @dhruvmanila