Skip to content

Remove redundent function in Backtracking Sudoku #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2021
Merged

Remove redundent function in Backtracking Sudoku #4499

merged 2 commits into from
Jun 10, 2021

Conversation

GDWR
Copy link
Contributor

@GDWR GDWR commented Jun 9, 2021 •
edited
Loading

Describe your change:

After reviewing this code, I've noticed that the is_completed function is a redundant operation.
Increasing the number of loops required for each step of the sudoku solver.
This should remove n² operations where n is the width of the grid.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@GDWR
Remove redundent function
04fd3b6 
After reviewing this code, I've noticed that the `is_completed` function is a redundant operation.
Increasing the number of loops required for each step of the sudoku solver. 
This should remove n² operations where n is the width of the grid.
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 9, 2021
@dhruvmanila
Copy link
Member

Closing and reopening for testing purposes.

@dhruvmanila dhruvmanila reopened this Jun 10, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Jun 10, 2021
@GDWR
Update sudoku.py
499440f 
Remove additional newline
@ghost ghost removed the tests are failing Do not merge until tests pass label Jun 10, 2021
@onlinejudge95 onlinejudge95 merged commit c824b90 into TheAlgorithms:master Jun 10, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 10, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@GDWR @shermanhui
Remove redundent function in Backtracking Sudoku (TheAlgorithms#4499)
d5db4e2 
* Remove redundent function

After reviewing this code, I've noticed that the `is_completed` function is a redundant operation.
Increasing the number of loops required for each step of the sudoku solver. 
This should remove n² operations where n is the width of the grid.

* Update sudoku.py

Remove additional newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GDWR @dhruvmanila @onlinejudge95