Skip to content

Add/fix mypy type annotations at BFS, DFS in graphs #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

mhihasan
Copy link
Contributor

@mhihasan mhihasan commented Jun 6, 2021

$ mypy --ignore-missing-imports graphs/breadth_first_search.py graphs/breadth_first_search_2.py graphs/depth_first_search.py graphs/depth_first_search_2.py

Success: no issues found in 4 source files

Related Issue: #4052

Describing change

  • Add/fix mypy type annoatation at BFS, DFS algo in graphs

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Releated to

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 6, 2021
@mhihasan mhihasan force-pushed the feature/fix_mypy_error branch from 2f07eae to ab95b7b Compare June 6, 2021 07:57
@ghost ghost added the tests are failing Do not merge until tests pass label Jun 8, 2021
@mhihasan mhihasan force-pushed the feature/fix_mypy_error branch from ab95b7b to fe6daa9 Compare June 9, 2021 03:13
@mhihasan mhihasan force-pushed the feature/fix_mypy_error branch from c329d0d to edd5a3e Compare June 9, 2021 03:59
@ghost ghost removed the tests are failing Do not merge until tests pass label Jun 10, 2021
@onlinejudge95 onlinejudge95 merged commit 977511b into TheAlgorithms:master Jun 10, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 10, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants