Skip to content

fix(action): correct indentation for types key #4445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2021
Merged

fix(action): correct indentation for types key #4445

merged 3 commits into from
May 21, 2021

Conversation

dhruvmanila
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila requested a review from cclauss as a code owner May 21, 2021 09:08
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels May 21, 2021
@dhruvmanila dhruvmanila merged commit ac29f70 into master May 21, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 21, 2021
@dhruvmanila dhruvmanila deleted the fix/action branch May 21, 2021 13:34
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila @shermanhui
fix(action): correct indentation for types key (TheAlgorithms#4445)
a8e5ba5 
* fix(action): correct indentation for types key

* updating DIRECTORY.md

* refactor: add quotes around name key

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @onlinejudge95