Skip to content

Wavelet tree #4267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 8, 2021
Merged

Wavelet tree #4267

merged 29 commits into from
Jun 8, 2021

Conversation

anirudnits
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Mar 14, 2021
ghost
ghost reviewed Mar 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/binary_tree/wavelet_tree.py Outdated


class Node:
def __init__(self, n):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: n

Please provide type hint for the parameter: n

data_structures/binary_tree/wavelet_tree.py Outdated
self.left: Optional[Node] = None
self.right: Optional[Node] = None

def __repr__(self):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function __repr__

Please provide return type hint for the function: __repr__. If the function does not return a value, please provide the type hint as: def function() -> None:

data_structures/binary_tree/wavelet_tree.py Outdated
return root


def rank_from_start(node: Node, num: int, i: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start

Please provide descriptive name for the parameter: i

data_structures/binary_tree/wavelet_tree.py Outdated
return rank_from_start(node.right, num, i - node.map_left[i])


def rank(node: Node, num: int, i: int, j: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank

Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: j

data_structures/binary_tree/wavelet_tree.py Outdated
return rank_till_j - rank_before_i


def quantile(node: Node, k: int, i: int, j: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function quantile

Please provide descriptive name for the parameter: k

Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: j

data_structures/binary_tree/wavelet_tree.py Outdated
)


def range_counting(node: Node, i: int, j: int, x: int, y: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function range_counting

Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: j

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

data_structures/binary_tree/wavelet_tree.py Outdated
return left + right


def main():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 14, 2021
ghost
ghost reviewed Mar 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/binary_tree/wavelet_tree.py Outdated


class Node:
def __init__(self, length):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: length

data_structures/binary_tree/wavelet_tree.py Outdated
self.left: Optional[Node] = None
self.right: Optional[Node] = None

def __repr__(self):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function __repr__

Please provide return type hint for the function: __repr__. If the function does not return a value, please provide the type hint as: def function() -> None:

data_structures/binary_tree/wavelet_tree.py Outdated
return root


def rank_from_start(node: Node, num: int, index: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start

data_structures/binary_tree/wavelet_tree.py Outdated
return rank_till_end - rank_before_start


def quantile(node: Node, k: int, start: int, end: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function quantile

Please provide descriptive name for the parameter: k

data_structures/binary_tree/wavelet_tree.py Outdated
)


def range_counting(node: Node, start: int, end: int, x: int, y: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function range_counting

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 14, 2021
@ghost ghost removed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Mar 14, 2021
ghost
ghost reviewed Mar 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/binary_tree/wavelet_tree.py Outdated
return root


def rank_from_start(node: Node, num: int, index: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start

@anirudnits @cclauss
Update data_structures/binary_tree/wavelet_tree.py
b96aefe 
Add doctests to placate the algorithm-bot, thanks to @cclauss.

Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
ghost reviewed Mar 27, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/binary_tree/wavelet_tree.py Outdated
return root


def rank_from_start(node: Node, num: int, index: int) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start

@cclauss
Copy link
Member

cclauss commented Apr 7, 2021

Let's get a review from @dhruvmanila first...

@dhruvmanila
Copy link
Member

Thanks for the heads up! I will take a look at it today.

@anirudnits
Copy link
Contributor Author

Just following up for any updates on this.

@anirudnits
Copy link
Contributor Author

Just following up for any updates.

@anirudnits
Copy link
Contributor Author

@cclauss @dhruvmanila just following up for any updates on this PR.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jun 8, 2021
@ghost ghost added the merge conflicts Open a new PR or rebase on the latest commit label Jun 8, 2021
@cclauss
Copy link
Member

cclauss commented Jun 8, 2021

Close and reopen to rebase…

@cclauss cclauss closed this Jun 8, 2021
@cclauss cclauss reopened this Jun 8, 2021
@ghost ghost added the enhancement This PR modified some existing files label Jun 8, 2021
@ghost ghost removed the merge conflicts Open a new PR or rebase on the latest commit label Jun 8, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 8, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Jun 8, 2021
@cclauss cclauss merged commit b743e44 into TheAlgorithms:master Jun 8, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 8, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@anirudnits @cclauss @shermanhui
Wavelet tree (TheAlgorithms#4267)
6874e4d 
* Added the matrix_exponentiation.py file in maths directory

* Implemented the requested changes

* Update matrix_exponentiation.py

* resolve merge conflict with upstream branch

* add new line at end of file

* add wavelet_tree

* fix isort issue

* updating DIRECTORY.md

* fix variable names in wavelet_tree and correct typo

* Add type hints and variable renaming

* Update data_structures/binary_tree/wavelet_tree.py

Add doctests to placate the algorithm-bot, thanks to @cclauss.

Co-authored-by: Christian Clauss <cclauss@me.com>

* Move doctest to individual functions and reformat code

* Move common test array to the global scope and reuse in tests

* MMove test array to global scope and minor linting changes

* Correct the failing pytest tests

* MUse built-in list for type annotation

* Update wavelet_tree.py

* types-requests

* updating DIRECTORY.md

* Update wavelet_tree.py

* # type: ignore

* # type: ignore

* Update decrypt_caesar_with_chi_squared.py

* ,

* Update decrypt_caesar_with_chi_squared.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Aniruddha Bhattacharjee <aniruddha@Aniruddhas-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anirudnits @cclauss @dhruvmanila