Skip to content

update area.py #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

update area.py #3862

merged 1 commit into from
Nov 18, 2020

Conversation

Suyeonkkk
Copy link
Contributor

@Suyeonkkk Suyeonkkk commented Nov 4, 2020 •
edited
Loading

add method "area_ellipse"

  • Calculate the area of an ellipse

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

update area.py
0aff326 
add method "area_ellipse"
- Calculate the area of a ellipse
@Suyeonkkk Suyeonkkk requested a review from Kush1101 as a code owner November 4, 2020 16:46
@mrmaxguns
Copy link
Member

Looks good. The area formula is correct and type hints, docstrings, and doctests are present.

@Suyeonkkk
Copy link
Contributor Author

Looks good. The area formula is correct and type hints, docstrings, and doctests are present.

Thanks! @mrmaxguns
:)

@Suyeonkkk
Copy link
Contributor Author

@poyea Could you please leave a review...??

poyea
poyea approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your pull request!🤩

@poyea poyea merged commit 8a134e1 into TheAlgorithms:master Nov 18, 2020
@Suyeonkkk Suyeonkkk deleted the develop branch November 19, 2020 11:03
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Suyeonkkk @stokhos
update area.py (TheAlgorithms#3862)
98c551f 
add method "area_ellipse"
- Calculate the area of a ellipse

Co-authored-by: 201502029 <tnehd158@naver.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@Suyeonkkk @peRFectBeliever
update area.py (TheAlgorithms#3862)
db3ddb4 
add method "area_ellipse"
- Calculate the area of a ellipse

Co-authored-by: 201502029 <tnehd158@naver.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Suyeonkkk
update area.py (TheAlgorithms#3862)
1baee0f 
add method "area_ellipse"
- Calculate the area of a ellipse

Co-authored-by: 201502029 <tnehd158@naver.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Suyeonkkk @shermanhui
update area.py (TheAlgorithms#3862)
e300807 
add method "area_ellipse"
- Calculate the area of a ellipse

Co-authored-by: 201502029 <tnehd158@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suyeonkkk @mrmaxguns @poyea