Skip to content

create monoalphabetic cipher #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 17, 2020
Merged

Conversation

radadiyamohit81
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@radadiyamohit81 radadiyamohit81 mentioned this pull request Oct 17, 2020
14 tasks
@TravisBuddy
Copy link

Travis tests have failed

Hey @radadiyamohit81,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2023a820-1083-11eb-af89-615b230ba186

@cclauss
Copy link
Member

cclauss commented Oct 17, 2020

Can you please do python3 -m pip install flake8 on your local computer and then.

flake8 mono_alphabetic_ciphers.py

@radadiyamohit81
Copy link
Contributor Author

let me try it

@radadiyamohit81
Copy link
Contributor Author

Thank you @cclauss, I learned new things from this Thank you so much

@cclauss
Copy link
Member

cclauss commented Oct 17, 2020

One last change needed...
charsA, charsB, symIndex, myMessage, myKey, myMode -->
chars_a, chars_b, sym_index, message, key, mode

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool... I would have simplified with from string import ascii_letters but this way works too.

@cclauss cclauss merged commit 2ec3750 into TheAlgorithms:master Oct 17, 2020
@radadiyamohit81
Copy link
Contributor Author

Ya its works too and Thank you so much

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* create monoalphabetic cipher

* update file

* update file

* update file

* update file

* update file

* update after testing flake8 on this code

* update file

* update file

* update file

* update file

* update file

* update file
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* create monoalphabetic cipher

* update file

* update file

* update file

* update file

* update file

* update after testing flake8 on this code

* update file

* update file

* update file

* update file

* update file

* update file
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* create monoalphabetic cipher

* update file

* update file

* update file

* update file

* update file

* update after testing flake8 on this code

* update file

* update file

* update file

* update file

* update file

* update file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants