Skip to content

Create natural_sort.py #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2020
Merged

Create natural_sort.py #3286

merged 8 commits into from
Oct 15, 2020

Conversation

Mozartuss
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Mozartuss Mozartuss requested a review from l3str4nge as a code owner October 14, 2020 14:09
@TravisBuddy
Copy link

Hey @Mozartuss,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 629a75f0-0e29-11eb-964d-5d54b4986782

cclauss
cclauss requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive!! A nice addition.

Mozartuss and others added 3 commits October 15, 2020 12:55
@Mozartuss @cclauss
Update sorts/natural_sort.py
d0f081d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@Mozartuss @cclauss
Update sorts/natural_sort.py
ad346f2 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
Update natural_sort.py
18e778e
cclauss
cclauss approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is elegant... A superpower in very few lines of code.

@cclauss cclauss merged commit f0033f8 into TheAlgorithms:master Oct 15, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Mozartuss @cclauss @stokhos
Create natural_sort.py (TheAlgorithms#3286)
fc0178d 
* add natural_sort.py

* fix doctest

* add 're' to requirements.txt and fix spelling errors

* delete 're' from requirements.txt

* fixing linting errors

* Update sorts/natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sorts/natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Mozartuss @cclauss
Create natural_sort.py (TheAlgorithms#3286)
48bb047 
* add natural_sort.py

* fix doctest

* add 're' to requirements.txt and fix spelling errors

* delete 're' from requirements.txt

* fixing linting errors

* Update sorts/natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sorts/natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update natural_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mozartuss @TravisBuddy @cclauss