Added decimal_to_binary_recursion.py [Hacktoberfest] #3266
Conversation
Travis tests have failedHey @cybov, TravisBuddy Request Identifier: 24876d50-0d97-11eb-9111-f326d0cb7f09 |
| Traceback (most recent call last): | ||
| ... | ||
| TypeError: unsupported operand type(s) for //: 'str' and 'int' | ||
| """ | ||
| # Initialize exit base of the recursion function | ||
| if decimal == 1 or decimal == 0: | ||
| return str(decimal) | ||
| return bin_recursive(decimal // 2) + str(decimal % 2) | ||
| result = binary_recursive(decimal // 2) + str(decimal % 2) | ||
| return str(result) |
There was a problem hiding this comment.
I am not a fan of this change. Creating a variable that has a lifetime of just two lines is not helpful unless it shortens a very long line or the variable name documents something that is not obvious. result in this context does neither. binary_recursive() is documented as returning a str so it is OK to add a str to it.
Travis tests have failedHey @cybov, TravisBuddy Request Identifier: 7f16bf20-0e03-11eb-964d-5d54b4986782 |
Travis tests have failedHey @cybov, TravisBuddy Request Identifier: d23de870-0e05-11eb-964d-5d54b4986782 |
Travis tests have failedHey @cybov, TravisBuddy Request Identifier: cc642580-0e06-11eb-964d-5d54b4986782 |
|
Nice modifications. How do i add the Hacktoberfest label sir? |
cybov
changed the title
* Added decimal_to_binary_recursion.py * Added decimal_to_binary_recursion.py * Made changes to docstring * Use divmod() * binary_recursive(div) + str(mod) * Be kind with user input if possible * Update decimal_to_binary_recursion.py * ValueError: invalid literal for int() with base 10: 'number' Co-authored-by: Christian Clauss <cclauss@me.com>
* Added decimal_to_binary_recursion.py * Added decimal_to_binary_recursion.py * Made changes to docstring * Use divmod() * binary_recursive(div) + str(mod) * Be kind with user input if possible * Update decimal_to_binary_recursion.py * ValueError: invalid literal for int() with base 10: 'number' Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.