Created Dijkstra's Two Stack Algorithm #2321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing purposes.
testing purposes.
cclauss
reviewed
Aug 17, 2020
| """ Stack Data Structure Used for the Algorithm""" | ||
| def __init__(self): | ||
| self.__array = [] | ||
| self.__len = 0 |
cclauss
requested changes
Aug 17, 2020
| self.__len = 0 | ||
| self.underflow_error = False | ||
|
|
||
| def is_empty(self): |
There was a problem hiding this comment.
We don’t need this method. if stack: is sufficient.
|
|
||
| def push(self, x): | ||
| self.__array.append(x) | ||
| self.__len += 1 |
There was a problem hiding this comment.
We don’t to need to do this busywork if __len__() returns len(self.array).
| self.__len += 1 | ||
|
|
||
| def pop(self): | ||
| if not self.is_empty(): |
There was a problem hiding this comment.
Suggested change
| if not self.is_empty(): | |
| if not self.array: | |
| raise IndexError("pop from empty list") |
just like [].pop()
| def peek(self): | ||
| return self.__array[-1] if not self.is_empty() else None | ||
|
|
||
| def length(self): |
| return self.__len | ||
|
|
||
| def print_stack(self): | ||
| print(self.__array) |
| pass | ||
|
|
||
| # RULE 5 | ||
| result = operand_stack.peek() |
There was a problem hiding this comment.
Suggested change
| result = operand_stack.peek() | |
| return operand_stack.peek() |
| def main(): | ||
| equation = "(5 + ((4 * 2) * (2 + 3)))" | ||
| # answer = 45 | ||
| answer = dijkstras_two_stack_algorithm(equation) |
There was a problem hiding this comment.
Suggested change
| answer = dijkstras_two_stack_algorithm(equation) | |
| print(f"{dijkstras_two_stack_algorithm(equation) = }") |
cclauss
reviewed
Aug 17, 2020
| print(self.__array) | ||
|
|
||
|
|
||
| def dijkstras_two_stack_algorithm(equation): |
Changed a few minor things.
Changed a few minor things.
cclauss
reviewed
Aug 19, 2020
Co-authored-by: Christian Clauss <cclauss@me.com>
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* created dijkstra's two stack algorithm * Made changes to dijkstras two stack algorithm for documentation and testing purposes. * Made changes to dijkstras two stack algorithm for documentation and testing purposes. * Fixed Grammar Mistake * Added Explanation Reference * Imported stack instead of using my own Changed a few minor things. * Imported stack instead of using my own Changed a few minor things. * Update data_structures/stacks/dijkstras_two_stack_algorithm.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update dijkstras_two_stack_algorithm.py Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.