remove function overhead #2233
Merged
remove function overhead #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add type hints
|
Hey @lance-pyles, TravisCI finished with status TravisBuddy Request Identifier: 9fad9e40-cde2-11ea-98fb-f5dcae6af814 |
cclauss
reviewed
Jul 24, 2020
| @@ -14,7 +14,7 @@ def surface_area_cube(side_length: Union[int, float]) -> float: | |||
| >>> surface_area_cube(3) | |||
| 54 | |||
| """ | |||
| return 6 * pow(side_length, 2) | |||
| return 6 * side_length ** 2 | |||
There was a problem hiding this comment.
Are we going to bounce back and forth every 48 hours? #2223 (review) ;-)
cclauss
reviewed
Jul 24, 2020
maths/area.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| from typing import Union | |||
There was a problem hiding this comment.
Travis not happy... ./maths/area.py:5:1: F401 'typing.Union' imported but unused
There was a problem hiding this comment.
I swear that line keeps coming back by itself :)
cclauss
approved these changes
Jul 24, 2020
|
Should I merge it quick before that import reappears?!? |
poyea
approved these changes
Jul 27, 2020
|
How about we just leave it there? Or we can ignore this file |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* remove function overhead add type hints * remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add type hints
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.