Skip to content

add Rankine scale #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2020
Merged

add Rankine scale #2232

merged 5 commits into from
Jul 24, 2020

Conversation

lance-pyles
Copy link
Contributor

black formatting

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
Copy link
Member

cclauss commented Jul 24, 2020

Cool! Python's builtin round() function takes an optional parameter ndigits. Should these functions each have an optional ndigits parameter that defaults to 2 but if the caller sets it then that values is passed down to the round call? This gives the caller more flexibility to set the precision if that helps in their use case. Thoughts?

cclauss
cclauss reviewed Jul 24, 2020
View reviewed changes
conversions/temperature_conversions.py Outdated
@@ -1,9 +1,11 @@
""" Convert between different units of temperature """


def celsius_to_fahrenheit(celsius: float) -> float:
def celsius_to_fahrenheit(celsius: float, digits: int = 2) -> float:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The round() parameter is ndigits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test or two to prove that ndigits is respected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests coming in a new PR

@TravisBuddy
Copy link

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6a6ee590-cdec-11ea-98fb-f5dcae6af814

@cclauss cclauss merged commit 99b40e2 into TheAlgorithms:master Jul 24, 2020
@lance-pyles lance-pyles deleted the rankine branch July 24, 2020 22:14
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@lance-pyles @stokhos
add Rankine scale (TheAlgorithms#2232)
6357e2a 
* add Rankine scale
black formatting

* add Wikipedia links

* add optional rounding, default to 2 digits

* fix variable name

* fixed variable name; helps to stage before commiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance-pyles @cclauss @TravisBuddy