Skip to content

sum_of_geometric_progression #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 10, 2020
Merged

sum_of_geometric_progression #2168

merged 10 commits into from
Jul 10, 2020

Conversation

AxSmasher44
Copy link
Contributor

Describe your change:

Implemented algorithm for finding the sum of 'n' terms of a geometric progression

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@AxSmasher44 AxSmasher44 changed the title Add files via upload sum_of_geometric_progression Jul 3, 2020
@TravisBuddy
Copy link

Hey @AxSmasher44,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 073b4e30-bd72-11ea-a595-8f8781864445

@cclauss
Copy link
Member

cclauss commented Jul 3, 2020

Does this work for floating point parameters? Does it work for negative parameters?

cclauss
cclauss requested changes Jul 3, 2020
View reviewed changes
AxSmasher44 and others added 3 commits July 4, 2020 14:26
@AxSmasher44 @cclauss
Update maths/sum_of_geometric_progression.py
04bc74a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AxSmasher44 @cclauss
Update maths/sum_of_geometric_progression.py
054f157 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AxSmasher44 @cclauss
Update maths/sum_of_geometric_progression.py
eb875ac 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AxSmasher44
Copy link
Contributor Author

Does this work for floating point parameters? Does it work for negative parameters?

Yes, it works for floating point parameters and negative parameters.

@TravisBuddy
Copy link

Hey @AxSmasher44,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: adf914c0-bdd4-11ea-a595-8f8781864445

@TravisBuddy
Copy link

Travis tests have failed

Hey @AxSmasher44,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a0878b30-bdd6-11ea-a595-8f8781864445

@TravisBuddy
Copy link

Hey @AxSmasher44,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 096e9190-be25-11ea-a595-8f8781864445

@cclauss
Copy link
Member

cclauss commented Jul 4, 2020 •
edited
Loading

Do these tests with zeros and negative numbers make sense or is this garbage data that should be detected and then rejected with a raise ValueError()?

Sahith02
Sahith02 approved these changes Jul 10, 2020
View reviewed changes
Copy link

@Sahith02 Sahith02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit 6c2c08c into TheAlgorithms:master Jul 10, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@AxSmasher44 @cclauss @stokhos
sum_of_geometric_progression (TheAlgorithms#2168)
8726816 
* Add files via upload

* Rename sum_of_Geometric_Progression.py to sum_of_geometric_progression.py

* Update sum_of_geometric_progression.py

* Update maths/sum_of_geometric_progression.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update maths/sum_of_geometric_progression.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update maths/sum_of_geometric_progression.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sum_of_geometric_progression.py

* Update sum_of_geometric_progression.py

* Type hints and test for zeros and negative numbers

* Update sum_of_geometric_progression.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Sahith02 Sahith02 Sahith02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AxSmasher44 @TravisBuddy @cclauss @Sahith02