Skip to content

double_linear_search algorithm #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 4, 2020
Merged

double_linear_search algorithm #2161

merged 11 commits into from
Jul 4, 2020

Conversation

reinhold-b
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @reinhold-b,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8ad70730-bc68-11ea-937a-75d40a178b7c

@TravisBuddy
Copy link

Hey @reinhold-b,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b5a678d0-bc6b-11ea-937a-75d40a178b7c

reinhold-b
reinhold-b commented Jul 2, 2020
View reviewed changes
Copy link
Contributor Author

@reinhold-b reinhold-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed whitespace in blank lines

reinhold-b
reinhold-b commented Jul 2, 2020
View reviewed changes
Copy link
Contributor Author

@reinhold-b reinhold-b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added blank after >>>

ruppysuppy
ruppysuppy reviewed Jul 3, 2020
View reviewed changes
Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need of examples in the main code, all examples should be in the doctests

@cclauss
Copy link
Member

cclauss commented Jul 3, 2020

There's no need of examples in the main code, all examples should be in the doctests

For me, I see no reason why we should limit the main code from having examples.

cclauss
cclauss requested changes Jul 3, 2020
View reviewed changes
searches/double_linear_search.py Outdated
"""Implementation of a double-linear-search,
which iterates through the array from both sides: start and end.

Change ARRAY_LENGTH to a number you want to generate an example array,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 4 - 10 should be moved into __main__ because they are not used by your function.

@TravisBuddy
Copy link

Hey @reinhold-b,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 539b6040-bd26-11ea-ab91-9125a069a76b

@reinhold-b reinhold-b requested a review from cclauss July 4, 2020 07:56
cclauss
cclauss approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@cclauss cclauss merged commit 64bef60 into TheAlgorithms:master Jul 4, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@reinhold-b @cclauss @stokhos
double_linear_search algorithm (TheAlgorithms#2161)
edd067b 
* linear search iterating from both array sides

* Update double_linear_search.py

* Update double_linear_search.py

* added doctests

* updated doctests

* Update double_linear_search.py

* Update double_linear_search.py

* added blank after >>>

* made all the requested changes

* Update double_linear_search.py

* Update double_linear_search.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reinhold-b @TravisBuddy @cclauss @ruppysuppy