Added Markov Chain #2146
Merged
Added Markov Chain #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Jun 23, 2020
other/markov_chain.py
Outdated
| self.connections[node1][node2] = probability | ||
|
|
||
| def get_nodes(self) -> List[str]: | ||
| return list(self.connections.keys()) |
There was a problem hiding this comment.
Suggested change
| return list(self.connections.keys()) | |
| return list(self.connections) |
.keys() is almost never needed in modern Python.
other/markov_chain.py
Outdated
|
|
||
| >>> result = get_transitions('a', transitions, 5000) | ||
|
|
||
| >>> assert result['a'] > result['b'] > result['c'] |
There was a problem hiding this comment.
Suggested change
| >>> assert result['a'] > result['b'] > result['c'] | |
| >>> result['a'] > result['b'] > result['c'] | |
| True |
other/markov_chain.py
Outdated
| for node1, node2, probability in transitions: | ||
| graph.add_transition_probability(node1, node2, probability) | ||
|
|
||
| visited = {node: 0 for node in graph.get_nodes()} |
There was a problem hiding this comment.
Suggested change
| visited = {node: 0 for node in graph.get_nodes()} | |
| visited = collections.Counter() |
(import collections at top of file)
https://docs.python.org/3/library/collections.html#collections.Counter
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added Markov Chain * Implemented suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: