Skip to content

Added minimum cost path algorithm #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

ruppysuppy
Copy link
Member

@ruppysuppy ruppysuppy commented Jun 19, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
Copy link
Member

cclauss commented Jun 19, 2020

What is the use case for this algorithm? What would be the real world value of solving this problem?

@ruppysuppy
Copy link
Member Author

I encountered it a long time back as a problem stating something like: "There is a gold digger travelling from the top left of the grid to the bottom right, help him maximize the gold he encounters on the path". Another variant of the problem can be considered quite useful, minimum path sum for matrix (can be done by changing the max of the top and left to the min of the two). If we, consider the path of a traveler in a N x M grid, the value for in the matrix can be considered accommodation cost and we are trying to minimize it.

@ruppysuppy
Copy link
Member Author

Let me know if its not worth adding. I'll close it. Planning to LRU Cache, but I can't understand where (which folder) I should add it in. Could you please tell me @cclauss ?

@itsvinayak
Copy link
Member

Let me know if its not worth adding. I'll close it. Planning to LRU Cache, but I can't understand where (which folder) I should add it in. Could you please tell me @cclauss ?

@ruppysuppy please add a description for this algorithm
if I am not wrong this problem is the same as this

@ruppysuppy
Copy link
Member Author

@itsvinayak should I change it to minimum cost path from maximum cost path? I'll add the description for the problem

@ruppysuppy ruppysuppy changed the title Added maximum path sum for matrix (top left to bottom right) Added minimum cost path algorithm Jul 2, 2020
Copy link
Member Author

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need more description?

@itsvinayak itsvinayak merged commit c534e77 into TheAlgorithms:master Jul 2, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added maximum path sum for matrix (top left to bottom right)

* Changed maximum cost path to minimum cost path + added video explaination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants