Skip to content

Create change_brightness.py #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2020
Merged

Create change_brightness.py #2126

merged 5 commits into from
Jun 17, 2020

Conversation

furkanatesli
Copy link
Contributor

@furkanatesli furkanatesli commented Jun 16, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @furkanatesli,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 523a7e50-b00d-11ea-ae15-c70b0cf57a1c

cclauss
cclauss requested changes Jun 16, 2020
View reviewed changes
@TravisBuddy
Copy link

Hey @furkanatesli,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b51e5250-b010-11ea-ae15-c70b0cf57a1c

@cclauss
Copy link
Member

cclauss commented Jun 16, 2020

What is the min and max value of level?

Please add these two carriage returns.
https://travis-ci.com/github/TheAlgorithms/Python/builds/171693668#L253

@TravisBuddy
Copy link

Hey @furkanatesli,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a7df85a0-b01f-11ea-ae15-c70b0cf57a1c

@cclauss
Copy link
Member

cclauss commented Jun 16, 2020

https://travis-ci.com/github/TheAlgorithms/Python/builds/171736313#L254

@furkanatesli furkanatesli requested a review from cclauss June 16, 2020 22:35
cclauss
cclauss reviewed Jun 16, 2020
View reviewed changes
digital_image_processing/change_brightness.py
from PIL import Image


def change_brightness(img: Image, level: float) -> Image:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... This looks ready to go. Thanks for doing this. Just a few more questions...

  1. Should level be a float or an int?
  2. What should be the minimum and maximum allowed values for level?
    • 0.0 to 1.0
    • -1.0 to 1.0
    • 0 to 100
    • 0 to 255
  3. If level is 0 then is the resulting image black?
  4. If the level is maxed then is the resulting image white or normal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. float
  2. -255.0 to 255.0
  3. No, if level 0 nothing changes.
  4. If the level is maximized, the resulting image is white

@itsvinayak itsvinayak requested a review from cclauss June 17, 2020 05:29
cclauss
cclauss approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution! Thanks for doing this.

@cclauss cclauss merged commit 6f80ca8 into TheAlgorithms:master Jun 17, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@furkanatesli @cclauss @stokhos
Create change_brightness.py (TheAlgorithms#2126)
80fd7fc 
* Create change_brightness.py

* Update change_brightness.py

* Update change_brightness.py

* Update change_brightness.py

* Update change_brightness.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkanatesli @TravisBuddy @cclauss