Skip to content

Add Z-function algorithm implementation #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2020
Merged

Add Z-function algorithm implementation #2067

merged 6 commits into from
Jun 11, 2020

Conversation

nikalosa
Copy link
Contributor

@nikalosa nikalosa commented Jun 3, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Jun 3, 2020
View reviewed changes
@cclauss
Copy link
Member

cclauss commented Jun 3, 2020

One Python file per pull request please.

@nikalosa
Copy link
Contributor Author

nikalosa commented Jun 3, 2020

One Python file per pull request please.

Sure, it was mistake. I'm going to make another PR for that file and accidentally I pushed here.

cclauss
cclauss requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to https://en.wikipedia.org/wiki/Z_function ?

@nikalosa
Copy link
Contributor Author

Is this related to https://en.wikipedia.org/wiki/Z_function ?

No that is not related to. Here are some additional links about the algorithm.

https://contest.cs.cmu.edu/295/tutorials/z-string-matching.pdf
https://codeforces.com/blog/entry/3107?
https://www.hackerearth.com/practice/algorithms/string-algorithm/z-algorithm/tutorial/#:~:text=One%20application%20of%20the%20Z,a%20character%20that%20matches%20nothing.

It is really often used efficient algorithm in competitive programming.

@TravisBuddy
Copy link

Hey @nikalosa,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d7afc9d0-ac04-11ea-a7dd-93c9ffbfb007

@TravisBuddy
Copy link

Hey @nikalosa,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b2fe24d0-ac07-11ea-a7dd-93c9ffbfb007

@nikalosa
Copy link
Contributor Author

Because of new merged file (./conversions/decimal_to_any.py), checks have failed for my code.

The log:
./conversions/decimal_to_any.py:104:17: E123 closing bracket does not match indentation of opening bracket's line

@cclauss cclauss merged commit 2264244 into TheAlgorithms:master Jun 11, 2020
@TravisBuddy
Copy link

Hey @nikalosa,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1369cce0-ac0b-11ea-a7dd-93c9ffbfb007

@nikalosa nikalosa deleted the z-function branch June 11, 2020 18:05
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@nikalosa @cclauss @stokhos
Add Z-function algorithm implementation (TheAlgorithms#2067)
28b5b03 
* Add Z-function algorithm implementation

* Spelling correction

* Reference url correction

* Add additional function as an example of z-function usage, change docstrings for functions

* Fix flake8 errors

* Update z_function.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikalosa @cclauss @TravisBuddy