Skip to content

circular_linked_list: Add more len() tests #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2020
Merged

circular_linked_list: Add more len() tests #2051

merged 6 commits into from
May 31, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented May 31, 2020 •
edited
Loading

Describe your change:

Add more len() and delete() tests

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from onlinejudge95 May 31, 2020 04:44
@cclauss cclauss mentioned this pull request May 31, 2020
Closed
onlinejudge95
onlinejudge95 reviewed May 31, 2020
View reviewed changes
Copy link
Collaborator

@onlinejudge95 onlinejudge95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check for black length required from my end

data_structures/linked_list/circular_linked_list.py Outdated
else:
while current_node.next_ptr != self.head:
current_node = current_node.next_ptr

current_node.next_ptr = self.head.next_ptr
self.head = self.head.next_ptr

self.length -= 1
self.length -= 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

onlinejudge95
onlinejudge95 reviewed May 31, 2020
View reviewed changes
strings/jaro_winkler.py
[(c1, c2) for c1, c2 in zip(matching_1, matching_2) if c1 != c2]
) // 2
transpositions = (
len([(c1, c2) for c1, c2 in zip(matching_1, matching_2) if c1 != c2]) // 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has a length of 82 chars, is it below our threshold?

Copy link
Member Author

@cclauss cclauss May 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black max_line_length is 88 characters.

@onlinejudge95 onlinejudge95 merged commit 1e8fe8e into master May 31, 2020
@onlinejudge95 onlinejudge95 deleted the circular_linked_list-len branch May 31, 2020 07:38
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
circular_linked_list: Add more len() tests (TheAlgorithms#2051)
90b49ec 
* circular_linked_list: Add more len() tests

* fixup! Format Python code with psf/black push

* prepend()

* updating DIRECTORY.md

* Fix decrementation of self.length

* Add empty list tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @onlinejudge95