Skip to content

Created weatherforecast.py #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2020
Merged

Created weatherforecast.py #2037

merged 3 commits into from
May 30, 2020

Conversation

swapnanildutta
Copy link
Contributor

@swapnanildutta swapnanildutta commented May 25, 2020 •
edited
Loading

Added weatherforecast.py to retrieve weather information of a location and return dictionary values.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@swapnanildutta
Created weatherforecast.py
5233ff3 
Added weatherforecast.py to retrieve weather information of a location and return dictionary values.
@swapnanildutta
Update weatherforecast.py
c097dc7
@cclauss
Copy link
Member

cclauss commented May 25, 2020 •
edited
Loading

This is cool but it contains a lot of boilerplate code that is no longer needed with the requests Package which is recommended in the Python Standard Library. Please consider rebuilding this using requests.

@cclauss
Copy link
Member

cclauss commented May 30, 2020

Nice one! Thanks for your contribution.

@cclauss cclauss merged commit f8bfd02 into TheAlgorithms:master May 30, 2020
@swapnanildutta
Copy link
Contributor Author

You're most welcome. Happy to contribute.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@swapnanildutta @cclauss @stokhos
Created weatherforecast.py (TheAlgorithms#2037)
f8dd473 
* Created weatherforecast.py

Added weatherforecast.py to retrieve weather information of a location and return dictionary values.

* Update weatherforecast.py

* Update and rename weatherforecast.py to current_weather.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swapnanildutta @cclauss