-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Fixes in Bidirectional A* #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
Thanks for doing this. I wrapped long lines w/ Note that this code confuses the flake8 linter because the return statements are of some functions are indented under if statements. There is no explicit returns when the if statement fails. As discussed in CONTRIBUTING.md, algorithm functions should not print(). They should raise exceptions or return None, etc. when bad things happen and leave it to the caller to print(), etc. |
* implement bidirectional astar * add type hints * add wikipedia url * format with black * changes from review * fix collision check * Add testmod() * # doctest: +NORMALIZE_WHITESPACE * Codespell: euclidean * Codespell: coordinates * Codespell: traversal * Codespell: remaining Co-authored-by: John Law <johnlaw.po@gmail.com> Co-authored-by: Christian Clauss <cclauss@me.com>
In the current state Bidirectional A* was not working due to an issue in the available vertices check. Could've been highlighted sooner but I only realized it as I added more doctests. Sorry about that.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.