Skip to content

README.md: sumab() --> sum_ab() for consistancy #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ We want your work to be readable by others; therefore, we encourage you to note
```python
def sum_ab(a, b):
"""
Returns the sum of two integers a and b
Return the sum of two integers a and b
>>> sum_ab(2, 2)
4
>>> sum_ab(-2, 3)
Expand Down Expand Up @@ -116,8 +116,8 @@ We want your work to be readable by others; therefore, we encourage you to note
The use of [Python type hints](https://docs.python.org/3/library/typing.html) is encouraged for function parameters and return values. Our automated testing will run [mypy](http://mypy-lang.org) so run that locally before making your submission.

```python
def sumab(a: int, b: int) --> int:
pass
def sum_ab(a: int, b: int) --> int:
return a + b
```

- [__List comprehensions and generators__](https://docs.python.org/3/tutorial/datastructures.html#list-comprehensions) are preferred over the use of `lambda`, `map`, `filter`, `reduce` but the important thing is to demonstrate the power of Python in code that is easy to read and maintain.
Expand Down
14 changes: 7 additions & 7 deletions data_structures/linked_list/middle_element_of_linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ class LinkedList:
def __init__(self):
self.head = None

def push(self, new_data:int) -> int:
new_node = Node(new_data)
new_node.next = self.head
def push(self, new_data: int) -> int:
new_node = Node(new_data)
new_node.next = self.head
self.head = new_node
return self.head.data

def middle_element(self) -> int:
'''
"""
>>> link = LinkedList()
>>> link.middle_element()
No element found.
Expand Down Expand Up @@ -44,11 +44,11 @@ def middle_element(self) -> int:
>>> link.middle_element()
12
>>>
'''
"""
slow_pointer = self.head
fast_pointer = self.head
if self.head:
while fast_pointer and fast_pointer.next:
if self.head:
while fast_pointer and fast_pointer.next:
fast_pointer = fast_pointer.next.next
slow_pointer = slow_pointer.next
return slow_pointer.data
Expand Down