Skip to content

Fix rehashing function will not call insert_data function #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_structures/hashing/double_hash.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __hash_function_2(self, value, data):
def __hash_double_function(self, key, data, increment):
return (increment * self.__hash_function_2(key, data)) % self.size_table

def _colision_resolution(self, key, data=None):
def _collision_resolution(self, key, data=None):
i = 1
new_key = self.hash_function(data)

Expand Down
3 changes: 2 additions & 1 deletion data_structures/hashing/hash_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ def rehashing(self):
self.size_table = next_prime(self.size_table, factor=2)
self._keys.clear()
self.values = [None] * self.size_table # hell's pointers D: don't DRY ;/
map(self.insert_data, survivor_values)
for value in survivor_values:
self.insert_data(value)

def insert_data(self, data):
key = self.hash_function(data)
Expand Down
4 changes: 2 additions & 2 deletions data_structures/hashing/hash_table_with_linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def balanced_factor(self):
* self.charge_factor
)

def _colision_resolution(self, key, data=None):
def _collision_resolution(self, key, data=None):
if not (
len(self.values[key]) == self.charge_factor and self.values.count(None) == 0
):
return key
return super()._colision_resolution(key, data)
return super()._collision_resolution(key, data)
2 changes: 1 addition & 1 deletion data_structures/hashing/quadratic_probing.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class QuadraticProbing(HashTable):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

def _colision_resolution(self, key, data=None):
def _collision_resolution(self, key, data=None):
i = 1
new_key = self.hash_function(key + i * i)

Expand Down