Add algorithm to rotate images #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Oct 22, 2019
| fig = plt.figure(1) | ||
| titles = ["Original", "Rotation 1", "Rotation 2", "Rotation 3"] | ||
| for i in range(0, len(images)): | ||
| plt.subplot(2, 2, i + 1), plt.imshow(images[i], "gray") |
There was a problem hiding this comment.
for i, image in enumerate(images):
plt.subplot(2, 2, i + 1), plt.imshow(image, "gray")
There was a problem hiding this comment.
Added enumerate in loop.
cclauss
reviewed
Oct 22, 2019
| import cv2 | ||
|
|
||
|
|
||
| def get_rotation(img, pt1, pt2, rows, cols): |
There was a problem hiding this comment.
Type hints? https://docs.python.org/3/library/typing.html
There was a problem hiding this comment.
Added type hints in get_rotation(). Thanks for the help!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add algorithm to rotate image * Edit function to be compliant in Black and Flake8 formats * Add type hints in get_rotation() and enumerate() in loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.