Skip to content

add simple improved Sieve Of Eratosthenes Algorithm #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

ShuLaPy
Copy link
Contributor

@ShuLaPy ShuLaPy commented Oct 21, 2019

No description provided.

@cclauss cclauss added the tests are failing Do not merge until tests pass label Oct 21, 2019
@cclauss
Copy link
Member

cclauss commented Oct 21, 2019

@cclauss
Copy link
Member

cclauss commented Oct 21, 2019

https://travis-ci.com/TheAlgorithms/Python/builds/132872849#L365
1 files contain uppercase characters:
maths/SieveOfEratosthenesPrimeNumber.py

@cclauss
Copy link
Member

cclauss commented Oct 21, 2019

This check is on the filename, not function name (although that is good too).

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

@cclauss cclauss merged commit a06995a into TheAlgorithms:master Oct 21, 2019
@ShuLaPy
Copy link
Contributor Author

ShuLaPy commented Oct 21, 2019

Thank you very much this is my first successful contribution.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* add simple improved Sieve Of Eratosthenes Algorithm

* added doctests

* name changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants