Skip to content

Create ActivitySelection #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 18, 2019
Merged

Conversation

swatiprajapati08
Copy link
Contributor

No description provided.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Filename does not end in .py
  2. Filename contains capital letters
  3. File contains legacy print statements
  4. No doctests or type hints

@cclauss cclauss added the awaiting changes A maintainer has requested changes to this PR label Oct 17, 2019
@cclauss
Copy link
Member

cclauss commented Oct 17, 2019

One step forward... Please keep it up. Make sure the Travis tests are passing.

@cclauss
Copy link
Member

cclauss commented Oct 17, 2019

https://travis-ci.com/TheAlgorithms/Python/builds/132386235#L351

Rename the file to other/activity_selection.py

@cclauss
Copy link
Member

cclauss commented Oct 18, 2019

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss cclauss merged commit 8366782 into TheAlgorithms:master Oct 18, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Create ActivitySelection

* Update and rename ActivitySelection to activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Rename activity_selection.py to other/activity_selection.py

* Update activity_selection.py

* Update activity_selection.py

* Add a doctest

* print(j, end=" ")

* print(i, end=" ")

* colons

* Add trailing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes A maintainer has requested changes to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants