Skip to content

Update treap.py #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 68 additions & 52 deletions data_structures/binary_tree/treap.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,103 +7,104 @@ class Node:
Treap's node
Treap is a binary tree by key and heap by priority
"""

def __init__(self, key: int):
self.key = key
self.prior = random()
self.l = None
self.r = None


def split(root: Node, key: int) -> Tuple[Node, Node]:
"""
We split current tree into 2 trees with key:
We split current tree into 2 trees with key:
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra indentation is not recommended by https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings


Left tree contains all keys less than split key.
Right tree contains all keys greater or equal, than split key
Left tree contains all keys less than split key.
Right tree contains all keys greater or equal, than split key
"""
if root is None: # None tree is split into 2 Nones
return (None, None)
if root.key >= key:
"""
Right tree's root will be current node.
Now we split(with the same key) current node's left son
Left tree: left part of that split
Right tree's left son: right part of that split
"""
l, root.l = split(root.l, key)
return (l, root)
else:
"""
Just symmetric to previous case
"""
root.r, r = split(root.r, key)
return (root, r)
if key < root.key:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation after a return statement makes this unreachable code. If you are using TABS for indentation then please stop. If you are using four spaces for indentation then please explain why this change is useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return is deleted...

"""
Right tree's root will be current node.
Now we split(with the same key) current node's left son
Left tree: left part of that split
Right tree's left son: right part of that split
"""
l, root.l = split(root.l, key)
return (l, root)
else:
"""
Just symmetric to previous case
"""
root.r, r = split(root.r, key)
return (root, r)


def merge(left: Node, right: Node) -> Node:
"""
We merge 2 trees into one.
Note: all left tree's keys must be less than all right tree's
"""
if (not left) or (not right):
"""
If one node is None, return the other
"""
if (not left) or (not right): # If one node is None, return the other
return left or right
if left.key > right.key:
elif left.prior < right.prior:
"""
Left will be root because it has more priority
Now we need to merge left's right son and right tree
Left will be root because it has more priority
Now we need to merge left's right son and right tree
"""
left.r = merge(left.r, right)
return left
else:
"""
Symmetric as well
Symmetric as well
"""
right.l = merge(left, right.l)
return right


def insert(root: Node, key: int) -> Node:
"""
Insert element
Insert element

Split current tree with a key into l, r,
Insert new node into the middle
Merge l, node, r into root
Split current tree with a key into l, r,
Insert new node into the middle
Merge l, node, r into root
"""
node = Node(key)
l, r = split(root, key)
root = merge(l, node)
root = merge(root, r)
return root

return merge(merge(l, node), r)

def erase(root: Node, key: int) -> Node:
"""
Erase element
Erase element

Split all nodes with keys less into l,
Split all nodes with keys greater into r.
Merge l, r
Split all nodes with keys less into l,
Split all nodes with keys greater into r.
Merge l, r
"""
l, r = split(root, key)
_, r = split(r, key + 1)
return merge(l, r)


def node_print(root: Node):
def pre_print(root: Node):
"""
Just recursive print of a tree
"""
if not root: # None
return
else:
pre_print(root.l)
print(root.key, end=" ")
pre_print(root.r)
def mid_print(root: Node):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put two blank lines between functions or better yet, reformat with black.

"""
show structure of the tree
"""
if not root:
return
node_print(root.l)
print(root.key, end=" ")
node_print(root.r)

else:
print(root.key, end=" ")
mid_print(root.l)
mid_print(root.r)

def interactTreap():
"""
Expand All @@ -114,17 +115,32 @@ def interactTreap():
After each command, program prints treap
"""
root = None
while True:
cmd = input().split()
cmd[1] = int(cmd[1])
print("enter numbers to creat a tree, + key to add key into treap, - key to erase all nodes with key. 'q' to quit. ")
cmd = input()
while cmd != 'q':
if cmd[0] == "+":
root = insert(root, cmd[1])
root = insert(root, int(cmd[1:]))
elif cmd[0] == "-":
root = erase(root, cmd[1])
root = erase(root, int(cmd[1:]))
else:
print("Unknown command")
node_print(root)
mid_print(root)
cmd = input()

def autoTreap():
root = None
print("example:")
cmds = ["+1", "+3", "+5", "+17", "+19", "+2", "+16", "+4", "+0", "+4", "+4", "+4", "-0", "-3", "-4", "-5", "-10", "+0", ]
for cmd in cmds:
print("\n>>>", cmd )
if cmd[0] == "+":
root = insert(root, int(cmd[1:]))
elif cmd[0] == "-":
root = erase(root, int(cmd[1:]))
mid_print(root)
print("\n")
pre_print(root)

if __name__ == "__main__":
autoTreap()
interactTreap()