Skip to content

added fibonacci_search.py #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Conversation

laishawadhwa
Copy link
Contributor

added a search methodology in python

@laishawadhwa
Copy link
Contributor Author

Kindly let me know what changes are required in the code?

Copy link
Member

@cozek cozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

Minor request, please add some doctests to your functions!
and line 34 inside a if __name__ == '__main__': . You can delete it if you want after adding the doctest since its essentially the same thing.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cclauss cclauss merged commit 9c63473 into TheAlgorithms:master Oct 18, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* added fibonacci_search.py

* added Fibonacci_search.py after error handling

* added doctests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants