Skip to content

Add unicode support in ciphers/base64_cipher.py script. #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

laurent-pck
Copy link
Contributor

No description provided.

@laurent-pck
Copy link
Contributor Author

This is a PR for the issue #1027

@cclauss
Copy link
Member

cclauss commented Oct 8, 2019

Please see a CONTRIBUTING.md and add doctests that contain Unicode characters.

@laurent-pck
Copy link
Contributor Author

Doctests added! I also changed the padding length computation to have no triple "=" padding (RFC 4648 section 4).

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution! Thanks!

@cclauss cclauss merged commit e177198 into TheAlgorithms:master Oct 18, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
…s#1316)

* Add unicode support in ciphers/base64_cipher.py script.

* Add doctests and correct the padding length computation in base64_cipher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants