Skip to content

Add Euler Project Problem 127 solution #12656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Euler Project Problem 127 solution #12656

wants to merge 3 commits into from
+109 −0

Conversation

mindaugl
Copy link
Contributor

@mindaugl mindaugl commented Apr 6, 2025

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

MaximSmolskiy
MaximSmolskiy requested changes Apr 14, 2025
View reviewed changes
Copy link
Member

@MaximSmolskiy MaximSmolskiy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindaugl Sorry, but 6 minutes is too long to accept such solution

386.85s call     scripts/validate_solutions.py::test_project_euler[problem_127/sol1.py]

The authors of the project mention the "one-minute rule" - https://projecteuler.net/about (now the longest accepted solution takes 10 seconds)

I've written my program but should it take days to get to the answer?
Absolutely not! Each problem has been designed according to a "one-minute rule", which means that although it may take several hours to design a successful algorithm with more difficult problems, an efficient implementation will allow a solution to be obtained on a modestly powered computer in less than one minute.

@algorithms-keeper algorithms-keeper bot added the awaiting changes A maintainer has requested changes to this PR label Apr 14, 2025
@mindaugl
Copy link
Contributor Author

Fair enough, was thinking this would be initial solution, as multiple solutions are allowed, on which to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting changes A maintainer has requested changes to this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mindaugl @MaximSmolskiy