Skip to content

Diophantine Equation #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OddExtension5
Copy link
Contributor

No description provided.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please consider adding doctests to the functions.

https://docs.python.org/3/library/doctest.html

@OddExtension5
Copy link
Contributor Author

okay sure!

@cclauss
Copy link
Member

cclauss commented Oct 2, 2019

  1. Awesome work! Thanks massively.
  2. OPTIONAL: Are there any other functions that could benefit from doctests?
  3. Instead of creating new directories (hashing/number_theory) can we fit these files this into data_structures/hashes) or should we create a new (data_structures/number_theory) directory. We want to avoid creating too many directories at the root and would like to reduce the nesting of directories. Your advise on categorization would be a big help.

@OddExtension5
Copy link
Contributor Author

  1. Thanks!
  2. Yes, but other functions are already created somewhere like extended_gcd, gcd, etc., and they have their doctest. So, according to me putting more doctest into my code is not required.
  3. No, we have to make a separate directory for number theory because hashing and number theory are different from each other. But we can reduce the nesting of directories by making one directory named Bitcoin or Blockchain as this field required knowledge of Hashing, Number Theory, Cryptography, Abstract(Modern) Algebra (Group Theory, Finite Fields) and Private&Public Key&Signature Algorithms.

P.S. If you made separate directory then it will be easier for me or others adding algorithms related to Blockchain and users can easily follow our directory. With that said In the future, I will add more algorithms related to bitcoin, for example, Schnorr Digital Signature Algorithm, Finite Field, Elliptic Curve Digital Signature Algorithm(ECDSA).

@OddExtension5
Copy link
Contributor Author

Closing in favour of #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants