Added Matrix Exponentiation #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
cclauss
requested changes
Sep 25, 2019
There was a problem hiding this comment.
Looking cool! A doctest or two would help https://docs.python.org/3/library/doctest.html
maths/matrix_exponentiation.py
Outdated
|
|
||
|
|
||
| fibonacci_with_matrix_exponentiation(n, f1, f2) | ||
| ''' |
There was a problem hiding this comment.
For readability, simplify this to:
code = "fibonacci_with_matrix_exponentiation(randint(1,70000), 1, 1)"
maths/matrix_exponentiation.py
Outdated
| ''' | ||
| exec_time = timeit.timeit(setup = setup, | ||
| stmt = code, | ||
| number = 100) |
There was a problem hiding this comment.
You might reformat your code with https://github.com/python/black
maths/matrix_exponentiation.py
Outdated
| stmt = code, | ||
| number = 100) | ||
|
|
||
| print ("Without matrix exponentiation the average execution time is ", exec_time/100) |
There was a problem hiding this comment.
No space between print and (. print() is a function call just like randint() is.
maths/matrix_exponentiation.py
Outdated
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
There was a problem hiding this comment.
🚫 GitHub editor is telling you to add a single carriage return at the end of your file.
|
Implemented the changes and re-submitted the PR, have a look. |
cclauss
approved these changes
Sep 25, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added the matrix_exponentiation.py file in maths directory * Implemented the requested changes * Update matrix_exponentiation.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180 Added the matrix_exponentiation.py file in maths directory