Deque #1200
Merged
Deque #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cozek
reviewed
Sep 30, 2019
There was a problem hiding this comment.
Hi, @paulo9428. Can you please answer me this. I can learn everything that you have written in your code by just reading the documentation on deque and moreover it is explained better in the documentation. So why should I read your code instead of directly reading the documentation?
cclauss
added a commit
that referenced
this pull request
Sep 30, 2019
Fixes #1200 As discussed on #1200 this file does not contain an algorithm as it does not implement a double ended queue but instead just uses the standard library's DEQ. @paulo9428 @cozek, @AnupKumarPanwar Your reviews please.
|
Sorry, i just wanna complement double ended queue methods of this file. I think this code has no ingenious points. So i agree with the pr the previous writter @cclauss push newly. And i also totally agree with your opinion. Thank you for your great advice. It was my first event of pushing pr. It leaves me great motive to comtribute on open source. I am satisfied just with that. |
cclauss
approved these changes
Sep 30, 2019
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Oct 3, 2019
Fixes TheAlgorithms#1200 As discussed on TheAlgorithms#1200 this file does not contain an algorithm as it does not implement a double ended queue but instead just uses the standard library's DEQ. @paulo9428 @cozek, @AnupKumarPanwar Your reviews please.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* deque add pop * deque add remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Double ended queue, added "pop", "popleft", "remove" method