Skip to content

feat: add testcases for longest_common_subsequence #11777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2024
Merged

feat: add testcases for longest_common_subsequence #11777

merged 1 commit into from
Oct 5, 2024

Conversation

zeelrupapara
Copy link
Contributor

@zeelrupapara zeelrupapara commented Oct 5, 2024 •
edited
Loading

Describe your change:

  • Add test cases of the longest_common_subsequence (increase test case coverage for that file by 5%)
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 5, 2024
@zeelrupapara zeelrupapara changed the title feat: add testcases of longest_common_subsequence to 75% feat: add testcases of longest_common_subsequence Oct 5, 2024
@zeelrupapara
Copy link
Contributor Author

zeelrupapara commented Oct 5, 2024 •
edited
Loading

Hi, could you please add the hacktoberfest-accepted label to this pull request to help it count towards Hacktoberfest? Thanks!

@zeelrupapara zeelrupapara changed the title feat: add testcases of longest_common_subsequence feat: add testcases for longest_common_subsequence Oct 5, 2024
@tianyizheng02 tianyizheng02 merged commit 50aca04 into TheAlgorithms:master Oct 5, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2024
@tianyizheng02
Copy link
Contributor

Hi, could you please add the hacktoberfest-accepted label to this pull request to help it count towards Hacktoberfest? Thanks!

Your PR will be accepted even without the "hacktoberfest-accepted" label because this repo is tagged with the "hacktoberfest" topic. See here: https://hacktoberfest.com/participation/

Your PR/MRs must be in a repo tagged with the “hacktoberfest” topic, or have the “hacktoberfest-accepted” label.

@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeelrupapara @tianyizheng02