Add Binomial Heap #1146
Merged
Add Binomial Heap #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of Binomial Heap. Reference: Advanced Data Structures, Peter Brass
- Fuller documentation of binomial heap - Update unit tests - Replace printing method by overwriting __str__()
cclauss
requested changes
Sep 3, 2019
cclauss
reviewed
Sep 3, 2019
cclauss
reviewed
Sep 3, 2019
cclauss
reviewed
Sep 3, 2019
cclauss
reviewed
Sep 3, 2019
- Added more tests - Added to the documentation - Stylistic editing - mergeHeaps now also returns a reference to the merged heap - added a preOrder function that returns a list with the preorder of the heap
|
Looks good to me but still needs to appear in our tests |
Would it help if I add some doctests in addition to the unit tests? |
|
Or get the unittests to be recognized by pytest. |
Changed the unit tests structure
cclauss
approved these changes
Sep 5, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Binomial Heap Implementation of Binomial Heap. Reference: Advanced Data Structures, Peter Brass * Update binomial_heap.py * Update binomial_heap.py * Update binomial_heap.py - Fuller documentation of binomial heap - Update unit tests - Replace printing method by overwriting __str__() * Update binomial_heap.py - Added more tests - Added to the documentation - Stylistic editing - mergeHeaps now also returns a reference to the merged heap - added a preOrder function that returns a list with the preorder of the heap * Update binomial_heap.py Changed the unit tests structure * Turned the tests into doctests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the binomial heap data structure.
Reference: Advanced Data Structures, Peter Brass