Skip to content

ENH: Added a functionality to make it possible to reconstruct an optimal subset for the dynamic programming problem #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2019

Conversation

maxwell-aladago
Copy link
Contributor

Also reformatted parts of the original file.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove legacy Python imports and add Python type hints.

"""
from __future__ import print_function, division, absolute_import
Copy link
Member

@cclauss cclauss Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo does not support legacy Python so these directives are not needed.

@cclauss cclauss self-assigned this Aug 18, 2019
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks! Please wrap line 2 so the file can be read on GitHub without left-right scrolling.

@cclauss cclauss merged commit 5d46a4d into TheAlgorithms:master Aug 19, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
…mal subset for the dynamic programming problem (TheAlgorithms#1139)

* function for the knapsack problem which returns one of the optimal subsets

* function for the knapsack problem which returns one of the optimal subsets

* function for the knapsack problem which returns one of the optimal subsets

* function for the knapsack problem which returns one of the optimal subsets

* function for the knapsack problem which returns one of the optimal subsets

* some pep8 cleanup too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants